forked from commonmark/cmark
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sourcepos, add missing extension tests and add sourcepos tests #223
Open
martincizek
wants to merge
27
commits into
github:master
Choose a base branch
from
orchitech:fix-sourcepos
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce position test case.
…n sourcepos tests unfortunately removed with github#49.
…ejected from header (sourcepos of such paragraph, the table and all nested elements are broken).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #222. This PR:
Quality assurance:
make test
passingmake leakcheck
is passing.CMARK_OPT_SOURCEPOS
is set, I've tried to set and unset this flag for parser only (not for the renderer), by hardcoding this incmark_parser_new_with_mem
. In both cases, all tests pass except for a few tests failing on sourcepos mismatch (which was expected).Performance - I wasn't able to measure any difference:
CMARK_OPT_SOURCEPOS
was hardcoded incmark_parser_new_with_mem
:I'd be glad if this is going to be fixed, as we now have to maintain own fork with fixed cmark-gfm and a our fork of commonmarker.
And any feedback would be welcome!